Bug 181311

Summary: Add assembler support for x86 lfence and sfence
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
msaboff: review+, msaboff: commit-queue+
patch
commit-queue: commit-queue-
patch none

JF Bastien
Reported 2018-01-04 15:21:21 PST
Useful for testing performance of serializing instructions (hint: it's not good).
Attachments
patch (3.05 KB, patch)
2018-01-04 15:23 PST, JF Bastien 		msaboff: review+
msaboff: commit-queue+
DetailsFormatted DiffDiff
patch (3.07 KB, patch)
2018-01-04 15:34 PST, JF Bastien 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
patch (3.07 KB, patch)
2018-01-04 15:52 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2018-01-04 15:22:33 PST
<rdar://problem/36301780>
JF Bastien
Comment 2 2018-01-04 15:23:41 PST
Created attachment 330492 [details] patch
JF Bastien
Comment 3 2018-01-04 15:34:39 PST
Created attachment 330493 [details] patch Not sure how mac32 fails to apply the patch... in any case, rebase to ToT.
WebKit Commit Bot
Comment 4 2018-01-04 15:36:28 PST
Comment on attachment 330493 [details] patch Rejecting attachment 330493 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 330493, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5930685
JF Bastien
Comment 5 2018-01-04 15:52:27 PST
Created attachment 330500 [details] patch Fix oops.
WebKit Commit Bot
Comment 6 2018-01-04 16:17:10 PST
Comment on attachment 330500 [details] patch Clearing flags on attachment: 330500 Committed r226428: <https://trac.webkit.org/changeset/226428>
WebKit Commit Bot
Comment 7 2018-01-04 16:17:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.