Bug 181291

Summary: [MediaStream] Add Mock screen capture source
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-01-04 08:46:12 PST
Add Mock screen capture source
Attachments
Patch (87.81 KB, patch)
2018-01-04 10:41 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-04 08:46:37 PST
<rdar://problem/36298164>
Eric Carlson
Comment 2 2018-01-04 10:41:16 PST
Created attachment 330474 [details] Patch
Dean Jackson
Comment 3 2018-01-04 11:48:31 PST
Comment on attachment 330474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review > Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74 > + double m_startTime { NAN }; > + double m_elapsedTime { 0 }; Should you use Seconds here, rather than a double?
WebKit Commit Bot
Comment 4 2018-01-04 12:12:31 PST
Comment on attachment 330474 [details] Patch Clearing flags on attachment: 330474 Committed r226412: <https://trac.webkit.org/changeset/226412>
WebKit Commit Bot
Comment 5 2018-01-04 12:12:33 PST
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 6 2018-01-04 14:31:52 PST
Comment on attachment 330474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review >> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74 >> + double m_elapsedTime { 0 }; > > Should you use Seconds here, rather than a double? Oops, I missed this suggestion. I will do this in an upcoming patch.
Chris Nardi
Comment 7 2018-01-04 22:04:09 PST
This patch seems to have caused a GTK compile issue (see for instance https://webkit-queues.webkit.org/results/5936753).
Eric Carlson
Comment 8 2018-01-05 09:13:31 PST
(In reply to Chris Nardi from comment #7) > This patch seems to have caused a GTK compile issue (see for instance > https://webkit-queues.webkit.org/results/5936753). Oops, sorry about that! Thanks to Zan for fixing this in r226438.
Note You need to log in before you can comment on or make changes to this bug.