| Summary: | [MediaStream] Add Mock screen capture source | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2018-01-04 08:46:12 PST
Created attachment 330474 [details]
Patch
Comment on attachment 330474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review > Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74 > + double m_startTime { NAN }; > + double m_elapsedTime { 0 }; Should you use Seconds here, rather than a double? Comment on attachment 330474 [details] Patch Clearing flags on attachment: 330474 Committed r226412: <https://trac.webkit.org/changeset/226412> All reviewed patches have been landed. Closing bug. Comment on attachment 330474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review >> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74 >> + double m_elapsedTime { 0 }; > > Should you use Seconds here, rather than a double? Oops, I missed this suggestion. I will do this in an upcoming patch. This patch seems to have caused a GTK compile issue (see for instance https://webkit-queues.webkit.org/results/5936753). (In reply to Chris Nardi from comment #7) > This patch seems to have caused a GTK compile issue (see for instance > https://webkit-queues.webkit.org/results/5936753). Oops, sorry about that! Thanks to Zan for fixing this in r226438. |