Bug 181261

Summary: NetworkProcess cache files use functions from unistd.h without explicitly including it
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, commit-queue, darin, don.olmstead, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add #includes for unistd.h none

Stephan Szabo
Reported 2018-01-03 15:46:24 PST
It seems like NetworkCacheBlobStorage.cpp and NetworkCacheData.cpp use things out of unistd.h (for example unlink) without explicitly including it.
Attachments
Add #includes for unistd.h (1.58 KB, patch)
2018-01-04 13:05 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-01-04 13:05:00 PST
Created attachment 330483 [details] Add #includes for unistd.h
WebKit Commit Bot
Comment 2 2018-01-04 14:33:05 PST
Comment on attachment 330483 [details] Add #includes for unistd.h Clearing flags on attachment: 330483 Committed r226423: <https://trac.webkit.org/changeset/226423>
WebKit Commit Bot
Comment 3 2018-01-04 14:33:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-01-04 14:34:18 PST
<rdar://problem/36306115>
Note You need to log in before you can comment on or make changes to this bug.