Bug 181229

Summary: Web Inspector: Clicking source location link in Console unexpectedly jumps to Network tab
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2018-01-02 16:59:20 PST
Clicking source location link in Console unexpectedly jumps to Network tab

We recently made it possible to open resources in the Network tab. In many cases we don't expect to jump there and would rather go to the Resources tab or Debugger tab, even if we were more recently in the Network Tab. Do our usual preferences of ignoring the Search and Network tabs.

Test:
<script>console.error("here");</script>

Steps to Reproduce:
1. Inspect test page
2. Show Network Tab
3. Show Elements Tab
4. Show Split Console
5. Click link next to "here"
  => Expected to go to Resources/Debugger tab and not Network tab
Comment 1 Joseph Pecoraro 2018-01-02 16:59:26 PST
<rdar://problem/36075219>
Comment 2 Joseph Pecoraro 2018-01-02 17:03:33 PST
Created attachment 330353 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2018-01-02 18:30:45 PST
Comment on attachment 330353 [details]
[PATCH] Proposed Fix

r=me, nice cleanup.
Comment 4 WebKit Commit Bot 2018-01-02 18:52:09 PST
Comment on attachment 330353 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330353

Committed r226347: <https://trac.webkit.org/changeset/226347>
Comment 5 WebKit Commit Bot 2018-01-02 18:52:10 PST
All reviewed patches have been landed.  Closing bug.