Bug 18120

Summary: Add more code emitters to squirrelfish
Product: WebKit Reporter: Sam Weinig <sam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch ggaren: review+

Sam Weinig
Reported 2008-03-26 12:31:39 PDT
Forthcoming patch add cursory emitCode support for NullNode, FalseNode, TrueNode, IfNode, IfElseNode, DoWhileNode and WhileNode.
Attachments
patch (12.18 KB, patch)
2008-03-26 12:36 PDT, Sam Weinig 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2008-03-26 12:36:46 PDT
Created attachment 20092 [details] patch
Geoffrey Garen
Comment 2 2008-03-26 22:23:21 PDT
Let's just have IfNode::emitCode, WhileNode::emitCode, and IfElseNode::emitCode return 0, with a FIXME, to avoid wallpapering over the underlying problem. r=me
Geoffrey Garen
Comment 3 2008-03-26 22:31:24 PDT
Please run sunspider --squirrelfish before landing.
Sam Weinig
Comment 4 2008-03-27 16:20:40 PDT
Landed in r31372.
Note You need to log in before you can comment on or make changes to this bug.