Bug 181176 – Remove op_assert and make @assert in builtins a function call so we have DFG/FTL coverage for builtins that use @assert in debug builds

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Saam Barati]

...

[Saam Barati]

Created attachment 330226 [details]
patch

[Yusuke Suzuki]

Comment on attachment 330226 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330226&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:875
> +            return generator.emitLoad(nullptr, jsUndefined());

Let’s load value to dst for consistency. And let’s check ignoreResult so that we do not need to emit unnecessary mov.

[Saam Barati]

Created attachment 330238 [details]
patch for landing

[EWS Watchlist]

Comment on attachment 330238 [details]
patch for landing

Attachment 330238 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5856372

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html

[EWS Watchlist]

Created attachment 330242 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Saam Barati]

(In reply to Build Bot from comment #4)
> Comment on attachment 330238 [details]
> patch for landing
> 
> Attachment 330238 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5856372
> 
> New failing tests:
> fast/mediastream/MediaStream-MediaElement-setObject-null.html

This is quite surprising. Building locally now to see if I can reproduce it.

[Saam Barati]

(In reply to Saam Barati from comment #6)
> (In reply to Build Bot from comment #4)
> > Comment on attachment 330238 [details]
> > patch for landing
> > 
> > Attachment 330238 [details] did not pass mac-wk2-ews (mac-wk2):
> > Output: http://webkit-queues.webkit.org/results/5856372
> > 
> > New failing tests:
> > fast/mediastream/MediaStream-MediaElement-setObject-null.html
> 
> This is quite surprising. Building locally now to see if I can reproduce it.

This fails for me locally without my changes. I'm going to land this patch.

[WebKit Commit Bot]

Comment on attachment 330238 [details]
patch for landing

Clearing flags on attachment: 330238

Committed r226310: <https://trac.webkit.org/changeset/226310>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36260843>

[Radar WebKit Bug Importer]

<rdar://problem/36260842>