Bug 181171

Summary: Web Inspector: [WinCairo] highlight inspector overlay aren't painted occasionally in HiDPI
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: inspector-bugzilla-changes, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 181320    
Bug Blocks:    
Attachments:
Description Flags
screenshots of OK case and NG case
none
WIP patch none

Fujii Hironori
Reported 2017-12-26 20:59:13 PST
Created attachment 330208 [details] screenshots of OK case and NG case See the screenshots of OK case and NG case. I tested with WinCiaro port MiniBrowser, Release build, trunk@226292. I don't know exact steps how to reproduce this bug. It's easy to produce by using Elements tab.
Attachments
screenshots of OK case and NG case (68.79 KB, image/png)
2017-12-26 20:59 PST, Fujii Hironori 		no flags
Details
WIP patch (616 bytes, patch)
2017-12-27 00:13 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-12-27 00:13:28 PST
Created attachment 330210 [details] WIP patch
Joseph Pecoraro
Comment 2 2017-12-28 10:50:04 PST
What was your test page. It seems weird that we would need to change the transform, I don’t think anything has changed there is years. Do you know if this is a Windows specific issue?
Fujii Hironori
Comment 3 2017-12-28 15:31:34 PST
It was the start page of Windows port MiniBrowser. I've confirmed it doesn't happen in AppleWin port and Linux GTK+ port. It must be a WinCairo port specific issue. My WIP patch must be a wrong fix even though it fixes this issue. I should fix WinCairo specific code anywhere.
Joseph Pecoraro
Comment 4 2017-12-28 20:53:26 PST
Seems like it might be an issue in WinCsiro GraphicsLayer impl? Almost seems like a context save is missing a restore (something unbalanced and leaving a transform where there should have been a transform).
Joseph Pecoraro
Comment 5 2018-01-02 11:54:28 PST
So was this fixed by bug 181173?
Fujii Hironori
Comment 6 2018-01-08 18:17:12 PST
I have confirmed this issue was fixed by Bug 181320. *** This bug has been marked as a duplicate of bug 181320 ***
Note You need to log in before you can comment on or make changes to this bug.