Summary: | WebKit fixes to enable -Wstrict-prototypes for Safari | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aestes, ews-watchlist, joepeck, mitz, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=180757 | ||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2017-12-23 17:09:52 PST
Created attachment 330172 [details]
Patch v1
Attachment 330172 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadRun.cpp:136: _WebThreadRun is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 330173 [details]
Patch v2
Attachment 330173 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadRun.cpp:136: _WebThreadRun is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 330173 [details] Patch v2 Attachment 330173 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5819881 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html Created attachment 330174 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 330173 [details] Patch v2 Clearing flags on attachment: 330173 Committed r226291: <https://trac.webkit.org/changeset/226291> All reviewed patches have been landed. Closing bug. |