Bug 181133 – generate_offset_extractor.rb should not print to stderr by default

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Catanzaro]

Currently we have a build that is completely quiet between CMake time and install time, with the sole exception of generate_offset_extractor.rb, which always prints one line to stderr:

[206/2826] Generating ../../DerivedSou...s/JavaScriptCore/LLIntDesiredOffsets.h
Only dealing with backends: ["X86_64"]

It doesn't seem to be adding any value. Can we just get rid of it?

[Michael Catanzaro]

Created attachment 330135 [details]
Patch

[Mark Lam]

(In reply to Michael Catanzaro from comment #0)
> Currently we have a build that is completely quiet between CMake time and
> install time, with the sole exception of generate_offset_extractor.rb, which
> always prints one line to stderr:
> 
> [206/2826] Generating
> ../../DerivedSou...s/JavaScriptCore/LLIntDesiredOffsets.h
> Only dealing with backends: ["X86_64"]
> 
> It doesn't seem to be adding any value. Can we just get rid of it?

Fil added this back in r172777. I suspect it is to aid in debugging whether the offlineasm successfully generated the expected backends (this is meaningful for builds that generate code for supporting multiple backends).

That said, I think that code in the offlineasm has been stable for years now, and it isn't that hard to add this print back should we need to debug this in the future.  So, I do not object to removing it.

[WebKit Commit Bot]

Comment on attachment 330135 [details]
Patch

Clearing flags on attachment: 330135

Committed r226270: <https://trac.webkit.org/changeset/226270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36197253>