Bug 181103

Summary: importScripts() inside a service worker should ensure that the response has a JavaScript MIME type
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-12-21 14:02:26 PST
importScripts() inside a service worker should ensure that the response has a JavaScript MIME type, as per: - https://w3c.github.io/ServiceWorker/#importscripts (step 6)
Attachments
Patch (7.84 KB, patch)
2017-12-21 14:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2017-12-22 12:50 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-12-21 14:10:09 PST
Created attachment 330065 [details] Patch
youenn fablet
Comment 2 2017-12-21 21:16:05 PST
Comment on attachment 330065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330065&action=review > Source/WebCore/workers/WorkerGlobalScope.cpp:271 > // FIXME: Fully implement https://w3c.github.io/ServiceWorker/#importscripts. Is this FIXME still relevant? If so, can it be made more precise? > LayoutTests/imported/w3c/ChangeLog:23 > + * web-platform-tests/service-workers/service-worker/registration-mime-types.https-expected.txt: Can we fix the test in this patch and submit a corresponding WPT PR. If we discover during the PR that we should revert the test change, we could update our WebKit WPT test and our implementation in a follow-up patch.
Chris Dumez
Comment 3 2017-12-22 12:50:30 PST
Created attachment 330139 [details] Patch
WebKit Commit Bot
Comment 4 2017-12-22 13:23:43 PST
Comment on attachment 330139 [details] Patch Clearing flags on attachment: 330139 Committed r226275: <https://trac.webkit.org/changeset/226275>
WebKit Commit Bot
Comment 5 2017-12-22 13:23:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-22 13:24:28 PST
<rdar://problem/36197500>
Note You need to log in before you can comment on or make changes to this bug.