Bug 181102

Summary: Rename NoEventDispatchAssertion to ScriptDisallowedScope
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Renamed
none
Patch for landing none

Ryosuke Niwa
Reported 2017-12-21 13:59:34 PST
It no longer makes sense to call this class NoEventDispatchAssertion given it's used to communicate the intent of never executing scripts whether it's an event, or a callback, etc...
Attachments
Renamed (64.13 KB, patch)
2017-12-21 14:05 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (62.17 KB, patch)
2017-12-21 14:26 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-12-21 14:05:58 PST
Created attachment 330062 [details] Renamed
Ryosuke Niwa
Comment 2 2017-12-21 14:26:47 PST
Created attachment 330069 [details] Patch for landing
Ryosuke Niwa
Comment 3 2017-12-21 14:27:54 PST
Comment on attachment 330069 [details] Patch for landing Wait for EWS.
EWS Watchlist
Comment 4 2017-12-21 14:30:51 PST
Attachment 330069 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Element.cpp:2478: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Element.cpp:2485: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Node.cpp:2338: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Node.cpp:2351: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/EventDispatcher.cpp:133: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/ContainerNode.cpp:126: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/ContainerNode.cpp:769: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/ContainerNode.cpp:786: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Document.cpp:4302: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Document.cpp:4310: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/Document.cpp:5145: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/EventTarget.cpp:218: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 12 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 5 2017-12-21 17:10:34 PST
Committed r226251: <https://trac.webkit.org/changeset/226251>
Radar WebKit Bug Importer
Comment 6 2017-12-21 17:11:52 PST
<rdar://problem/36188468>
Note You need to log in before you can comment on or make changes to this bug.