Bug 181094

Summary: [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2017-12-21 11:42:15 PST
ssia
Attachments
Patch (3.23 KB, patch)
2017-12-21 11:44 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2017-12-21 12:26 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-12-21 11:44:26 PST
Created attachment 330046 [details] Patch
Antti Koivisto
Comment 2 2017-12-21 11:46:12 PST
Comment on attachment 330046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330046&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:65 > + auto insertInternal = [&](RenderElement& parentCandidate) { I bet there is a better name somewhere!
alan
Comment 3 2017-12-21 11:46:51 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 330046 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330046&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:65 > > + auto insertInternal = [&](RenderElement& parentCandidate) { > > I bet there is a better name somewhere! I am 100% sure there is!
alan
Comment 4 2017-12-21 12:26:15 PST
Created attachment 330050 [details] Patch
Antti Koivisto
Comment 5 2017-12-21 12:58:08 PST
Comment on attachment 330050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330050&action=review > Source/WebCore/ChangeLog:3 > + [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal Lies.
WebKit Commit Bot
Comment 6 2017-12-21 12:59:16 PST
Comment on attachment 330050 [details] Patch Clearing flags on attachment: 330050 Committed r226237: <https://trac.webkit.org/changeset/226237>
WebKit Commit Bot
Comment 7 2017-12-21 12:59:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-12-21 13:00:34 PST
<rdar://problem/36183940>
alan
Comment 9 2017-12-21 13:28:03 PST
(In reply to Antti Koivisto from comment #5) > Comment on attachment 330050 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330050&action=review > > > Source/WebCore/ChangeLog:3 > > + [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal > > Lies. so true!
Note You need to log in before you can comment on or make changes to this bug.