Bug 181083

Summary: [DFG] Unify bunch of DFG 32bit code into 64bit code
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+, commit-queue: commit-queue-

Description Yusuke Suzuki 2017-12-21 03:46:01 PST
[DFG] Unify bunch of DFG 32bit code into 64bit code
Comment 1 Yusuke Suzuki 2017-12-21 03:50:17 PST
Created attachment 330027 [details]
Patch
Comment 2 Build Bot 2017-12-21 04:52:33 PST
Comment on attachment 330027 [details]
Patch

Attachment 330027 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/5787915

New failing tests:
microbenchmarks/super-get-by-val-with-this-monomorphic.js.dfg-maximal-flush-validate-no-cjit
microbenchmarks/super-get-by-val-with-this-monomorphic.js.default
stress/super-property-access-exceptions.js.dfg-eager
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-no-cjit-validate-sampling-profiler
microbenchmarks/super-get-by-val-with-this-monomorphic.js.no-cjit-validate-phases
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-no-cjit-b3o1
stress/super-property-access-exceptions.js.ftl-eager-no-cjit-b3o1
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-eager
stress/super-property-access.js.no-cjit-validate-phases
stress/super-property-access-exceptions.js.default
stress/super-property-access-exceptions.js.no-llint
stress/super-property-access-exceptions.js.ftl-no-cjit-no-inline-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-no-cjit-no-put-stack-validate
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-no-cjit-b3o1
stress/super-property-access-exceptions.js.dfg-maximal-flush-validate-no-cjit
microbenchmarks/super-get-by-val-with-this-monomorphic.js.no-ftl
microbenchmarks/super-get-by-val-with-this-polymorphic.js.default
stress/super-property-access-exceptions.js.ftl-no-cjit-b3o1
stress/super-property-access.js.no-cjit-collect-continuously
microbenchmarks/super-get-by-val-with-this-polymorphic.js.no-ftl
microbenchmarks/super-get-by-val-with-this-monomorphic.js.no-cjit-collect-continuously
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-no-cjit-small-pool
stress/super-property-access-exceptions.js.ftl-no-cjit-validate-sampling-profiler
stress/super-property-access.js.ftl-no-cjit-no-put-stack-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-no-cjit-no-inline-validate
stress/super-property-access.js.ftl-eager-no-cjit-b3o1
stress/super-property-access.js.ftl-no-cjit-b3o1
microbenchmarks/super-get-by-val-with-this-monomorphic.js.dfg-eager-no-cjit-validate
microbenchmarks/super-get-by-val-with-this-monomorphic.js.dfg-eager
stress/super-property-access-exceptions.js.no-cjit-collect-continuously
stress/super-property-access.js.default
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-no-cjit-validate-sampling-profiler
microbenchmarks/super-get-by-val-with-this-polymorphic.js.dfg-maximal-flush-validate-no-cjit
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-no-cjit-no-put-stack-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.no-cjit-validate-phases
stress/super-property-access-exceptions.js.ftl-no-cjit-no-put-stack-validate
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-eager-no-cjit
microbenchmarks/super-get-by-val-with-this-polymorphic.js.dfg-eager
stress/super-property-access.js.ftl-eager
microbenchmarks/super-get-by-val-with-this-polymorphic.js.no-cjit-collect-continuously
stress/super-property-access.js.dfg-maximal-flush-validate-no-cjit
microbenchmarks/super-get-by-val-with-this-monomorphic.js.no-llint
stress/super-property-access.js.ftl-no-cjit-no-inline-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.dfg-eager-no-cjit-validate
stress/super-property-access.js.ftl-no-cjit-validate-sampling-profiler
stress/super-property-access.js.no-llint
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-no-cjit-small-pool
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-no-cjit-no-inline-validate
stress/super-property-access-exceptions.js.no-ftl
stress/super-property-access-exceptions.js.no-cjit-validate-phases
stress/super-property-access.js.dfg-eager
microbenchmarks/super-get-by-val-with-this-monomorphic.js.ftl-eager-no-cjit-b3o1
stress/super-property-access.js.ftl-eager-no-cjit
stress/super-property-access.js.no-ftl
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-eager-no-cjit
microbenchmarks/super-get-by-val-with-this-polymorphic.js.no-llint
stress/super-property-access.js.dfg-eager-no-cjit-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-eager
stress/super-property-access-exceptions.js.ftl-eager
stress/super-property-access-exceptions.js.dfg-eager-no-cjit-validate
microbenchmarks/super-get-by-val-with-this-polymorphic.js.ftl-eager-no-cjit-b3o1
Comment 3 Yusuke Suzuki 2017-12-21 05:00:33 PST
Created attachment 330028 [details]
Patch
Comment 4 Mark Lam 2017-12-21 13:57:28 PST
Comment on attachment 330028 [details]
Patch

r=me.  Nice job.
Comment 5 Yusuke Suzuki 2017-12-22 00:01:05 PST
Comment on attachment 330028 [details]
Patch

Thanks!
Comment 6 WebKit Commit Bot 2017-12-22 00:22:02 PST
Comment on attachment 330028 [details]
Patch

Rejecting attachment 330028 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 330028, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   78b6594..83443c9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 226259 = 78b659443ebc2bae756a59e6bed5056c27a8a0bc
r226260 = 83443c9dda1e7109aa3cf48afd9b16b21dc63056
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/5799419
Comment 7 Yusuke Suzuki 2017-12-22 01:07:41 PST
Committed r226261: <https://trac.webkit.org/changeset/226261>
Comment 8 Radar WebKit Bug Importer 2017-12-22 01:09:07 PST
<rdar://problem/36192906>