Bug 18104

Summary: REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: slewis
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Make sure to destroy unmatched clean lines andersca: review+

mitz
Reported 2008-03-25 23:43:17 PDT
editing/inserting/12882.html leaks two InlineBox instances. This is a regression from the incremental line layout with floats patch(es).
Attachments
Make sure to destroy unmatched clean lines (2.28 KB, patch)
2008-03-26 13:40 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2008-03-26 01:20:02 PDT
// If a float's geometry has changed, give up on syncing with clean lines. if (floats[floatIndex].rect != IntRect(f->m_left, f->m_top, f->m_width, f->m_bottom - f->m_top)) endLine = 0; The idea was to avoid the endLineMatched condition, but zeroing out endLine also avoids the "Delete all the remaining lines" branch, leading to the leak.
mitz
Comment 2 2008-03-26 13:40:14 PDT
Created attachment 20096 [details] Make sure to destroy unmatched clean lines No layout test regressions
Anders Carlsson
Comment 3 2008-03-26 13:48:06 PDT
Comment on attachment 20096 [details] Make sure to destroy unmatched clean lines r=me
mitz
Comment 4 2008-03-26 13:54:32 PDT
Fixed in <http://trac.webkit.org/projects/webkit/changeset/31328>.
Note You need to log in before you can comment on or make changes to this bug.