Bug 181013 – Refactor user-installed font setting for clarity

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Refactor user-installed font setting for clarity

[Myles C. Maxfield]

Created attachment 329858 [details]
Patch

[Myles C. Maxfield]

Created attachment 329859 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 329858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329858&action=review

> Source/WebCore/platform/graphics/FontDescription.h:188
> +    unsigned m_shouldAllowUserInstalledFonts : 1; // If this description is allowed to match a user-installed font

The comment should mention the name of the enum.

> Source/WebCore/platform/text/TextFlags.h:367
> +    Yes,
> +    No

Maybe better to flip these so that No is 0 in case this gets cast to a bool context.

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:118
> -@property (nonatomic, setter=_setShouldDisallowUserInstalledFonts:) BOOL _shouldDisallowUserInstalledFonts WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> +@property (nonatomic, setter=_setShouldAllowUserInstalledFonts:) BOOL _shouldAllowUserInstalledFonts WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

I presume no-one is using this yet?

[Simon Fraser (smfr)]

Comment on attachment 329859 [details]
Patch

Please see my comments on the previous patch.

[Myles C. Maxfield]

Comment on attachment 329858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329858&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:118
>> +@property (nonatomic, setter=_setShouldAllowUserInstalledFonts:) BOOL _shouldAllowUserInstalledFonts WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> I presume no-one is using this yet?

Correct.

[Myles C. Maxfield]

Committed r226172: <https://trac.webkit.org/changeset/226172>

[Radar WebKit Bug Importer]

<rdar://problem/36147318>