Bug 180998

Summary: Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2017-12-19 14:09:09 PST
Network Table - Update the Time column to include the total duration not just the download duration It was confusing to have the "Time" not match the popover. Previously it was just the download duration, which excluded the queueing / connection time, which can grow large. Just make this the total time.
Attachments
[PATCH] Proposed Fix (4.39 KB, patch)
2017-12-19 14:16 PST, Joseph Pecoraro
mattbaker: review+
Radar WebKit Bug Importer
Comment 1 2017-12-19 14:10:14 PST
Joseph Pecoraro
Comment 2 2017-12-19 14:16:59 PST
Created attachment 329822 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2017-12-19 15:21:22 PST
Comment on attachment 329822 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329822&action=review r=me, with a comment. > Source/WebInspectorUI/UserInterface/Models/Resource.js:545 > + get downloadDuration() Are there plans to use `downloadDuration` in the very near future? If not let's remove it. I think `totalDuration` makes sense as a name event with out, since we have a `receiveDuration`.
Joseph Pecoraro
Comment 4 2017-12-19 15:31:09 PST
(In reply to Matt Baker from comment #3) > Comment on attachment 329822 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329822&action=review > > r=me, with a comment. > > > Source/WebInspectorUI/UserInterface/Models/Resource.js:545 > > + get downloadDuration() > > Are there plans to use `downloadDuration` in the very near future? If not > let's remove it. I think `totalDuration` makes sense as a name event with > out, since we have a `receiveDuration`. Okay, I'll remove it.
Joseph Pecoraro
Comment 5 2017-12-19 15:40:42 PST
Note You need to log in before you can comment on or make changes to this bug.