Bug 180981

Summary:

Refactor MessagePortChannel family classes for an easier multi-process split

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Preliminary for an EWS run	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
EWS run	none
EWS run	none
Patch	aestes: review+, aestes: commit-queue-
Patch for landing	none

Brady Eidson

Reported 2017-12-19 10:58:19 PST

Refactor MessagePortChannel family classes for an easier multi-process split

Attachments
Preliminary for an EWS run (44.12 KB, patch) 2017-12-20 09:39 PST, Brady Eidson	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (2.13 MB, application/zip) 2017-12-20 10:41 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.69 MB, application/zip) 2017-12-20 10:54 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (3.26 MB, application/zip) 2017-12-20 11:02 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (8.00 MB, application/zip) 2017-12-20 11:03 PST, EWS Watchlist	no flags	Details
EWS run (44.23 KB, patch) 2017-12-20 21:42 PST, Brady Eidson	no flags	Details Formatted Diff Diff
EWS run (44.81 KB, patch) 2017-12-20 22:02 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (48.20 KB, patch) 2017-12-20 22:40 PST, Brady Eidson	aestes: review+ aestes: commit-queue-	Details Formatted Diff Diff
Patch for landing (48.20 KB, patch) 2017-12-21 09:52 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-12-20 09:39:55 PST

Created attachment 329927 [details] Preliminary for an EWS run

Brady Eidson

Comment 2 2017-12-20 09:40:18 PST

(Might rely on the patch over in https://bugs.webkit.org/show_bug.cgi?id=94458 landed first)

EWS Watchlist

Comment 3 2017-12-20 09:42:51 PST

Attachment 329927 [details] did not pass style-queue: ERROR: Source/WebCore/dom/InProcessMessagePortChannel.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2017-12-20 10:41:44 PST

Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5775857 New failing tests: fast/events/message-channel-gc-3.html

EWS Watchlist

Comment 5 2017-12-20 10:41:45 PST

Created attachment 329931 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2017-12-20 10:54:34 PST

Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5775873 New failing tests: fast/events/message-channel-gc-3.html

EWS Watchlist

Comment 7 2017-12-20 10:54:36 PST

Created attachment 329935 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 8 2017-12-20 11:02:35 PST

Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5775888 New failing tests: fast/events/message-channel-gc-3.html

EWS Watchlist

Comment 9 2017-12-20 11:02:36 PST

Created attachment 329936 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 10 2017-12-20 11:03:29 PST

Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5775850 New failing tests: fast/events/message-channel-gc-3.html

EWS Watchlist

Comment 11 2017-12-20 11:03:30 PST

Created attachment 329937 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Brady Eidson

Comment 12 2017-12-20 14:54:08 PST

fast/events/message-channel-gc-3.html fails. It creates a MessageChannel, sends a message from one port to the other, then makes sure the MessageChannel is GC'ed before the message is delivered. In debugging I can see that when the MessageChannel goes away, it takes its MessagePorts with it (even though it should not!) So with my patch, nothing is protecting the ports, but something used to be.

Brady Eidson

Comment 13 2017-12-20 21:42:38 PST

Created attachment 330006 [details] EWS run

Brady Eidson

Comment 14 2017-12-20 22:02:18 PST

Created attachment 330007 [details] EWS run

Brady Eidson

Comment 15 2017-12-20 22:40:06 PST

Created attachment 330010 [details] Patch

Andy Estes

Comment 16 2017-12-21 08:52:28 PST

Comment on attachment 330010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330010&action=review > Source/WebCore/dom/InProcessMessagePortChannel.cpp:25 > + */ > +#include "config.h" Missing a newline

Brady Eidson

Comment 17 2017-12-21 09:52:23 PST

Created attachment 330034 [details] Patch for landing

WebKit Commit Bot

Comment 18 2017-12-21 17:17:49 PST

Comment on attachment 330034 [details] Patch for landing Clearing flags on attachment: 330034 Committed r226252: <https://trac.webkit.org/changeset/226252>

Radar WebKit Bug Importer

Comment 19 2018-01-02 12:58:50 PST

<rdar://problem/36260877>

Note You need to log in before you can comment on or make changes to this bug.