| Summary: | Refactor MessagePortChannel family classes for an easier multi-process split | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | aestes, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, rniwa, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | Other | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Brady Eidson
2017-12-19 10:58:19 PST
Created attachment 329927 [details]
Preliminary for an EWS run
(Might rely on the patch over in https://bugs.webkit.org/show_bug.cgi?id=94458 landed first) Attachment 329927 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/InProcessMessagePortChannel.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5775857 New failing tests: fast/events/message-channel-gc-3.html Created attachment 329931 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5775873 New failing tests: fast/events/message-channel-gc-3.html Created attachment 329935 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5775888 New failing tests: fast/events/message-channel-gc-3.html Created attachment 329936 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329927 [details] Preliminary for an EWS run Attachment 329927 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5775850 New failing tests: fast/events/message-channel-gc-3.html Created attachment 329937 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
fast/events/message-channel-gc-3.html fails. It creates a MessageChannel, sends a message from one port to the other, then makes sure the MessageChannel is GC'ed before the message is delivered. In debugging I can see that when the MessageChannel goes away, it takes its MessagePorts with it (even though it should not!) So with my patch, nothing is protecting the ports, but something used to be. Created attachment 330006 [details]
EWS run
Created attachment 330007 [details]
EWS run
Created attachment 330010 [details]
Patch
Comment on attachment 330010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330010&action=review > Source/WebCore/dom/InProcessMessagePortChannel.cpp:25 > + */ > +#include "config.h" Missing a newline Created attachment 330034 [details]
Patch for landing
Comment on attachment 330034 [details] Patch for landing Clearing flags on attachment: 330034 Committed r226252: <https://trac.webkit.org/changeset/226252> |