Bug 180955 – Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync

• Component: WebKit API
• Status: RESOLVED FIXED

[Jeff Miller]

Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync on macOS. The equivalent C SPI was tracked by <https://bugs.webkit.org/show_bug.cgi?id=163292>.

[Radar WebKit Bug Importer]

<rdar://problem/36118898>

[Jeff Miller]

Created attachment 338269 [details]
Patch

[Jeff Miller]

Looks like this broke non-Mac builds, I'll upload a new patch.

[Jeff Miller]

Created attachment 338270 [details]
Patch

[Jeff Miller]

Now it seems like the builders are failing for other reasons unrelated to this patch.

[Alex Christensen]

Comment on attachment 338270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338270&action=review

> Source/WebKit/UIProcess/API/APIContextMenuClient.h:61
> -    virtual RetainPtr<NSMenu> menuFromProposedMenu(WebKit::WebPageProxy&, NSMenu *menu, const WebKit::WebHitTestResultData&, API::Object*) { return menu; }
> +    virtual bool useGetContextMenuFromProposedNSMenu() { return false; }
> +    virtual void getContextMenuFromProposedNSMenu(WebKit::WebPageProxy&, NSMenu *proposedMenu, WebKit::WebContextMenuListenerProxy& listener, API::Object* /* userData */) { listener.useContextMenuNSMenu(proposedMenu); }

This feels like the wrong approach.  I think the right approach would make menuFromProposedMenu return void and have it have a CompletionHandler<void(RetainPtr<NSMenu>)>&& as its last parameter.

> Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp:58
> +void WebContextMenuListenerProxy::useContextMenuNSMenu(NSMenu *menu)

The Linux build was indeed failing because it was trying to compile this.

> Source/WebKit/UIProcess/WebContextMenuListenerProxy.h:50
>      void useContextMenuItems(Vector<Ref<WebContextMenuItem>>&&);
> +    void useContextMenuNSMenu(NSMenu *);

It seems like we should package things so we don't need to add another function here.

[Alex Christensen]

Created attachment 338688 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338688 [details]
Patch

Clearing flags on attachment: 338688

Committed r231174: <https://trac.webkit.org/changeset/231174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.