Bug 180939

Summary:

Service Worker should not clean HTTP headers added by the application or by fetch specification before service worker interception

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, commit-queue, dbates, ews-watchlist, ggaren, japhet, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none

youenn fablet

Reported 2017-12-18 12:41:51 PST

Accept header and headers set by a web application should not be cleaned when going through service workers.

Attachments
Patch (35.95 KB, patch) 2017-12-18 13:00 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (35.99 KB, patch) 2017-12-18 13:46 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.51 MB, application/zip) 2017-12-18 15:02 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.14 MB, application/zip) 2017-12-18 15:13 PST, EWS Watchlist	no flags	Details
Patch (36.91 KB, patch) 2017-12-18 15:18 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (42.57 KB, patch) 2017-12-18 15:37 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (36.91 KB, patch) 2017-12-18 15:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-12-18 13:00:28 PST

Created attachment 329661 [details] Patch

youenn fablet

Comment 2 2017-12-18 13:02:08 PST

https://github.com/w3c/web-platform-tests/pull/8729

youenn fablet

Comment 3 2017-12-18 13:46:03 PST

Created attachment 329675 [details] Patch

EWS Watchlist

Comment 4 2017-12-18 15:02:56 PST

Comment on attachment 329675 [details] Patch Attachment 329675 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5730941 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html

EWS Watchlist

Comment 5 2017-12-18 15:02:58 PST

Created attachment 329688 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2017-12-18 15:13:24 PST

Comment on attachment 329675 [details] Patch Attachment 329675 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5730940 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html

EWS Watchlist

Comment 7 2017-12-18 15:13:25 PST

Created attachment 329690 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 8 2017-12-18 15:18:47 PST

Created attachment 329691 [details] Patch

Chris Dumez

Comment 9 2017-12-18 15:32:45 PST

Patch does not apply.

youenn fablet

Comment 10 2017-12-18 15:33:59 PST

(In reply to Chris Dumez from comment #9) > Patch does not apply. Same patch as previously, except one new PASS... I am rebuilding on top of blob patch to reproduce the new PASS the bots have discovered :)

youenn fablet

Comment 11 2017-12-18 15:37:43 PST

Created attachment 329693 [details] Patch

youenn fablet

Comment 12 2017-12-18 15:57:38 PST

Created attachment 329698 [details] Patch

WebKit Commit Bot

Comment 13 2017-12-19 10:37:48 PST

Comment on attachment 329698 [details] Patch Clearing flags on attachment: 329698 Committed r226126: <https://trac.webkit.org/changeset/226126>

WebKit Commit Bot

Comment 14 2017-12-19 10:37:50 PST

All reviewed patches have been landed. Closing bug.