Bug 180936

Summary: Conditionally forward declare NSMapTable SPI
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Web Template FrameworkAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2017-12-18 10:50:55 PST
Remove include of obsolete header NSMapTablePriv.h.
Attachments
Patch (1.15 KB, patch)
2017-12-18 11:07 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2017-12-18 13:01 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2017-12-18 13:02 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-12-18 10:51:15 PST
<rdar://problem/35037796>
Daniel Bates
Comment 2 2017-12-18 11:07:09 PST
(In reply to Daniel Bates from comment #0) > Remove include of obsolete header NSMapTablePriv.h. Actually, we need to continue including this header for a bit longer.
Daniel Bates
Comment 3 2017-12-18 11:07:55 PST
Created attachment 329655 [details] Patch
mitz
Comment 4 2017-12-18 12:13:13 PST
Comment on attachment 329655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329655&action=review > Source/WTF/wtf/spi/cocoa/NSMapTableSPI.h:28 > +#if USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 120000 This has the effect of using the below declarations in the __IPHONE_OS_VERSION_MAX_ALLOWED >= 120000 case. But I think we shouldn’t make those declarations in that case, because they are already bade in NSMapTable.h, which we import above. My understanding is that the entire SPI header is only needed for older SDK versions (which don’t have the declarations in their NSMapTable.h), so it would be nice to express that with guards around the entire thing.
Daniel Bates
Comment 5 2017-12-18 13:01:51 PST
Created attachment 329662 [details] Patch
Daniel Bates
Comment 6 2017-12-18 13:02:57 PST
Created attachment 329663 [details] Patch
Daniel Bates
Comment 7 2017-12-18 13:23:59 PST
Comment on attachment 329663 [details] Patch Clearing flags on attachment: 329663 Committed r226073: <https://trac.webkit.org/changeset/226073>
Daniel Bates
Comment 8 2017-12-18 13:24:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.