Bug 180897

Summary: Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182443
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Alex Christensen
Reported 2017-12-15 17:52:19 PST
Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
Attachments
Patch (6.07 KB, patch)
2017-12-15 17:54 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.59 KB, patch)
2017-12-21 16:35 PST, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-12-15 17:54:35 PST
Created attachment 329549 [details] Patch
Alex Christensen
Comment 2 2017-12-21 16:35:18 PST
Created attachment 330077 [details] Patch
Brent Fulgham
Comment 3 2017-12-28 13:54:26 PST
Comment on attachment 330077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330077&action=review r=me > Source/WebKit/ChangeLog:20 > + (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted. These were just renamed to match their purpose, right? > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:885 > + */ Did you mean to leave this commented-out code?
Alex Christensen
Comment 4 2018-01-02 09:22:04 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 330077 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330077&action=review > > r=me > > > Source/WebKit/ChangeLog:20 > > + (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted. > > These were just renamed to match their purpose, right? Right. > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:885 > > + */ > > Did you mean to leave this commented-out code? I removed it for now. http://trac.webkit.org/r226325
Radar WebKit Bug Importer
Comment 5 2018-01-02 12:56:53 PST
<rdar://problem/36260832>
youenn fablet
Comment 6 2018-02-02 11:31:47 PST
When changing the website data store, there is the possibility that a page will now need to check service worker registration while it was not needed previously. We should add some logic to fix that.
youenn fablet
Comment 7 2018-02-02 11:32:44 PST
Filed bug 182443 to follow on service worker aspects
Note You need to log in before you can comment on or make changes to this bug.