| Summary: | Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=182443 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2017-12-15 17:52:19 PST
Created attachment 329549 [details]
Patch
Created attachment 330077 [details]
Patch
Comment on attachment 330077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330077&action=review r=me > Source/WebKit/ChangeLog:20 > + (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted. These were just renamed to match their purpose, right? > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:885 > + */ Did you mean to leave this commented-out code? (In reply to Brent Fulgham from comment #3) > Comment on attachment 330077 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330077&action=review > > r=me > > > Source/WebKit/ChangeLog:20 > > + (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted. > > These were just renamed to match their purpose, right? Right. > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:885 > > + */ > > Did you mean to leave this commented-out code? I removed it for now. http://trac.webkit.org/r226325 When changing the website data store, there is the possibility that a page will now need to check service worker registration while it was not needed previously. We should add some logic to fix that. Filed bug 182443 to follow on service worker aspects |