Bug 180892

Summary: [Attachment Support] Support representing pasted or dropped content using attachment elements
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 180853    
Bug Blocks: 180924    
Attachments:
Description Flags
Depends on https://bugs.webkit.org/show_bug.cgi?id=180853
thorton: review+
Rebase on master
none
Rebase on master again none

Wenson Hsieh
Reported 2017-12-15 16:36:45 PST
<rdar://problem/36064210>
Attachments
Depends on https://bugs.webkit.org/show_bug.cgi?id=180853 (28.07 KB, patch)
2017-12-15 22:44 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Rebase on master (25.25 KB, patch)
2017-12-18 16:35 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on master again (25.21 KB, patch)
2017-12-18 18:49 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-12-15 22:44:23 PST
Created attachment 329561 [details] Depends on https://bugs.webkit.org/show_bug.cgi?id=180853
Tim Horton
Comment 2 2017-12-18 13:18:56 PST
Comment on attachment 329561 [details] Depends on https://bugs.webkit.org/show_bug.cgi?id=180853 View in context: https://bugs.webkit.org/attachment.cgi?id=329561&action=review > Source/WebCore/ChangeLog:10 > + replaceRichContentWithAttachmentsIfNecessary to replace object elements with attachments; see comments below for Still slightly concerned about all <object>s becoming <attachment>s. > Source/WebCore/ChangeLog:28 > + of generating markup from NSTextAttachments; this currently causes the web process to crash on an unrecognized > + selector. Crazy
Wenson Hsieh
Comment 3 2017-12-18 13:49:08 PST
Comment on attachment 329561 [details] Depends on https://bugs.webkit.org/show_bug.cgi?id=180853 View in context: https://bugs.webkit.org/attachment.cgi?id=329561&action=review >> Source/WebCore/ChangeLog:10 >> + replaceRichContentWithAttachmentsIfNecessary to replace object elements with attachments; see comments below for > > Still slightly concerned about all <object>s becoming <attachment>s. True, it's...kinda weird. One caveat is that we only do this replacement for objects whose `data` have already been replaced by blob URLs. And for pasted/dropped <object>s that don't have data URLs or haven't been blob-replaced, we'll simply remove them from the inserted fragment. >> Source/WebCore/ChangeLog:28 >> + selector. > > Crazy 🙃 Thankfully less so after this change.
Wenson Hsieh
Comment 4 2017-12-18 16:35:16 PST
Created attachment 329707 [details] Rebase on master
Wenson Hsieh
Comment 5 2017-12-18 18:49:00 PST
Created attachment 329724 [details] Rebase on master again
WebKit Commit Bot
Comment 6 2017-12-18 20:03:25 PST
Comment on attachment 329724 [details] Rebase on master again Clearing flags on attachment: 329724 Committed r226093: <https://trac.webkit.org/changeset/226093>
Note You need to log in before you can comment on or make changes to this bug.