Bug 180886

Summary:

Implement getting ServiceWorker registrations for the WKWebsiteDataStore API

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-12-15 14:55:23 PST

Implement getting ServiceWorker registrations for the WKWebsiteDataStore API

Attachments
Patch (9.02 KB, patch) 2017-12-15 15:28 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (9.10 KB, patch) 2017-12-15 15:53 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (9.11 KB, patch) 2017-12-15 15:58 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (8.71 KB, patch) 2017-12-15 16:15 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-12-15 15:28:35 PST

Created attachment 329525 [details] Patch

Brady Eidson

Comment 2 2017-12-15 15:53:06 PST

Created attachment 329531 [details] Patch

Chris Dumez

Comment 3 2017-12-15 15:57:41 PST

Comment on attachment 329525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329525&action=review r=me with comments. Also please fix GTK/WPE build. > Source/WebCore/workers/service/server/SWServer.cpp:796 > + while (!m_getOriginsWithRegistrationsCallbacks.isEmpty()) Why bother we the container mutations? How about we make m_getOriginsWithRegistrationsCallbacks a Vector and use: auto getOriginsWithRegistrationsCallbacks = WTFMove(m_getOriginsWithRegistrationsCallbacks); for (auto& callback : getOriginsWithRegistrationsCallbacks) callback(originsWithRegistrations); Seems like this would be more efficient. > Source/WebCore/workers/service/server/SWServer.h:238 > + Deque<WTF::Function<void(const HashSet<SecurityOriginData>&)>> m_getOriginsWithRegistrationsCallbacks; Seems like this could be a Vector. > Source/WebKit/StorageProcess/StorageProcess.cpp:273 > + for (auto& origin : *originsWithServiceWorkers) Why isn't this in the swServerForSession(sessionID).getOriginsWithRegistrations() lambda? Similarly to what is done for IndexedDB? Then we do not need originsWithServiceWorkers / rawOrigins either.

Brady Eidson

Comment 4 2017-12-15 15:58:39 PST

Created attachment 329532 [details] Patch

Brady Eidson

Comment 5 2017-12-15 16:15:32 PST

Created attachment 329535 [details] Patch

WebKit Commit Bot

Comment 6 2017-12-16 10:54:09 PST

Comment on attachment 329535 [details] Patch Clearing flags on attachment: 329535 Committed r226003: <https://trac.webkit.org/changeset/226003>

WebKit Commit Bot

Comment 7 2017-12-16 10:54:10 PST

All reviewed patches have been landed. Closing bug.