Bug 180885

Summary: Plugin processes are repeatedly spun up to do nothing
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, bfulgham, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2017-12-15 14:49:03 PST
The code in 'WebsiteDataStore::removeData' calls State::deleteData, even if there are no hostnames with data to be deleted. This causes a PluginProcess to be spun up for each plugin type, which is told to delete data from no websites. The processes then shut down. We shouldn't be doing this.
Attachments
Patch (1.32 KB, patch)
2017-12-15 15:10 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.21 KB, patch)
2017-12-15 16:34 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-15 14:50:53 PST
<rdar://problem/36082564>
Brent Fulgham
Comment 2 2017-12-15 15:07:08 PST
I noticed this problem while doing further debugging and testing after the changes for Bug 180819. However, this bug existed before then.
Brent Fulgham
Comment 3 2017-12-15 15:10:02 PST
Created attachment 329523 [details] Patch
Brent Fulgham
Comment 4 2017-12-15 15:11:23 PST
Another fix might be to have State::deleteData() return early if hostNames or plugins is empty.
Brent Fulgham
Comment 5 2017-12-15 15:14:44 PST
Yikes! That has been that way since 2015!
Geoffrey Garen
Comment 6 2017-12-15 15:15:55 PST
Comment on attachment 329523 [details] Patch r=me
Geoffrey Garen
Comment 7 2017-12-15 15:18:22 PST
Can we API test this? Seems like the kind of subtle mistake that might happen again.
Brent Fulgham
Comment 8 2017-12-15 16:34:10 PST
Created attachment 329538 [details] Patch for landing
WebKit Commit Bot
Comment 9 2017-12-16 09:57:13 PST
Comment on attachment 329538 [details] Patch for landing Clearing flags on attachment: 329538 Committed r225999: <https://trac.webkit.org/changeset/225999>
WebKit Commit Bot
Comment 10 2017-12-16 09:57:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.