Summary: | Plugin processes are repeatedly spun up to do nothing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, beidson, bfulgham, commit-queue, ggaren, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brent Fulgham
2017-12-15 14:49:03 PST
I noticed this problem while doing further debugging and testing after the changes for Bug 180819. However, this bug existed before then. Created attachment 329523 [details]
Patch
Another fix might be to have State::deleteData() return early if hostNames or plugins is empty. Yikes! That has been that way since 2015! Comment on attachment 329523 [details]
Patch
r=me
Can we API test this? Seems like the kind of subtle mistake that might happen again. Created attachment 329538 [details]
Patch for landing
Comment on attachment 329538 [details] Patch for landing Clearing flags on attachment: 329538 Committed r225999: <https://trac.webkit.org/changeset/225999> All reviewed patches have been landed. Closing bug. |