Bug 180879

Summary:

webkitpy: Newline when MeteredStream is cleaned up

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

NEW

Severity:

Normal

CC:

ews-watchlist, glenn, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jbedard: review-

Jonathan Bedard

Reported 2017-12-15 13:01:09 PST

Without a newline when cleaning up the MeteredStream, programs often end without a new line (run-webkit-tests, in particular)

Attachments
Patch (1.30 KB, patch) 2017-12-15 13:16 PST, Jonathan Bedard	jbedard: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2017-12-15 13:16:30 PST

Created attachment 329512 [details] Patch

Radar WebKit Bug Importer

Comment 2 2017-12-15 13:16:42 PST

<rdar://problem/36080173>

Radar WebKit Bug Importer

Comment 3 2017-12-15 13:16:44 PST

<rdar://problem/36080175>

Jonathan Bedard

Comment 4 2017-12-15 14:32:33 PST

Comment on attachment 329512 [details] Patch This isn't quite correct. What we're looking to do here is to output a newline if the metered stream was the last one to print to stderr. This output results in an extra newline if there is something else which has printed to stderr between the last metered print and teardown.

Note You need to log in before you can comment on or make changes to this bug.