Bug 180875

Summary: [WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, darin, fujii.hironori, lforschler, pvollan, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch none

Basuke Suzuki
Reported 2017-12-15 11:31:46 PST
The repository's root is not good to keep downloaded files. Move it into WebKitLibraries. Also register them and extracted files to gitignore.
Attachments
patch (2.31 KB, patch)
2017-12-15 12:10 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2017-12-18 00:22 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-12-15 12:10:58 PST
Created attachment 329504 [details] patch
WebKit Commit Bot
Comment 2 2017-12-16 10:33:34 PST
Comment on attachment 329504 [details] patch Clearing flags on attachment: 329504 Committed r226002: <https://trac.webkit.org/changeset/226002>
WebKit Commit Bot
Comment 3 2017-12-16 10:33:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-12-16 10:37:43 PST
<rdar://problem/36091434>
Fujii Hironori
Comment 5 2017-12-18 00:14:41 PST
update-webkit-wincairo-libs.py gets broken by this change. > Updating WinCairoRequirements.zip... > No existing release found. > Seeking latest release from WebKitForWindows/WinCairoRequirements... > ('Found latest release:', u'v2017.11.16') > Downloading to C:\webkit\ga\WebKitLibraries\win... > Done! > Extracting release to WebKitLibraries/win... > Traceback (most recent call last): > File "Tools/Scripts/update-webkit-wincairo-libs.py", line 41, in <module> > zip = zipfile.ZipFile(file, 'r') > File "C:\tools\python27\lib\zipfile.py", line 756, in __init__ > self.fp = open(file, modeDict[mode]) > IOError: [Errno 2] No such file or directory: 'WinCairoRequirements.zip' > Died at Tools\Scripts\build-webkit line 242.
Fujii Hironori
Comment 6 2017-12-18 00:22:28 PST
Created attachment 329642 [details] Patch
Basuke Suzuki
Comment 7 2017-12-18 10:36:06 PST
My bad. Sorry about my silly mistake.
WebKit Commit Bot
Comment 8 2017-12-18 10:52:05 PST
Comment on attachment 329642 [details] Patch Clearing flags on attachment: 329642 Committed r226062: <https://trac.webkit.org/changeset/226062>
WebKit Commit Bot
Comment 9 2017-12-18 10:52:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.