Bug 180868

Summary: ExtendableMessageEvent.data should return the value it was initialized to
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-12-15 10:04:58 PST
ExtendableMessageEvent.data should return the value it was initialized to. We currently store a serialized version in the implementation and deserialize it when the data getter is called.
Attachments
Patch (7.20 KB, patch)
2017-12-15 10:24 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-12-15 10:24:32 PST
Created attachment 329497 [details] Patch
Geoffrey Garen
Comment 2 2017-12-18 13:34:40 PST
Comment on attachment 329497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329497&action=review r=me > Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:41 > + UNUSED_PARAM(throwScope); I think you used throwScope, so you shouldn't need this.
WebKit Commit Bot
Comment 3 2017-12-18 13:56:57 PST
Comment on attachment 329497 [details] Patch Clearing flags on attachment: 329497 Committed r226078: <https://trac.webkit.org/changeset/226078>
WebKit Commit Bot
Comment 4 2017-12-18 13:56:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-18 13:57:23 PST
<rdar://problem/36115203>
Note You need to log in before you can comment on or make changes to this bug.