Bug 180848

Summary: check-webkit-style: Stop warning about underscores in webrtc source
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, joepeck, lforschler, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180757
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2017-12-14 16:45:05 PST
Warnings about underscores in function names in webrtc code should be suppressed.
Attachments
Patch v1 (1.56 KB, patch)
2017-12-14 16:48 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.50 KB, patch)
2017-12-14 16:52 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-12-14 16:48:51 PST
Created attachment 329421 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2017-12-14 16:52:32 PST
Created attachment 329423 [details] Patch v2
Joseph Pecoraro
Comment 3 2017-12-14 19:04:55 PST
Comment on attachment 329423 [details] Patch v2 rs=me
Joseph Pecoraro
Comment 4 2017-12-14 19:05:40 PST
Comment on attachment 329423 [details] Patch v2 r=me. You changed the existing comment. Did you want to keep both?
Joseph Pecoraro
Comment 5 2017-12-14 19:06:08 PST
Comment on attachment 329423 [details] Patch v2 Oh it said `and`! cq+
WebKit Commit Bot
Comment 6 2017-12-14 19:26:31 PST
Comment on attachment 329423 [details] Patch v2 Clearing flags on attachment: 329423 Committed r225957: <https://trac.webkit.org/changeset/225957>
WebKit Commit Bot
Comment 7 2017-12-14 19:26:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-12-14 19:28:10 PST
<rdar://problem/36065806>
Note You need to log in before you can comment on or make changes to this bug.