Bug 180848

Summary: check-webkit-style: Stop warning about underscores in webrtc source
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, joepeck, lforschler, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180757
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2017-12-14 16:45:05 PST 
Warnings about underscores in function names in webrtc code should be suppressed.
Comment 1 David Kilzer (:ddkilzer) 2017-12-14 16:48:51 PST 
Created attachment 329421 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2017-12-14 16:52:32 PST 
Created attachment 329423 [details]
Patch v2
Comment 3 Joseph Pecoraro 2017-12-14 19:04:55 PST 
Comment on attachment 329423 [details]
Patch v2

rs=me
Comment 4 Joseph Pecoraro 2017-12-14 19:05:40 PST 
Comment on attachment 329423 [details]
Patch v2

r=me. You changed the existing comment. Did you want to keep both?
Comment 5 Joseph Pecoraro 2017-12-14 19:06:08 PST 
Comment on attachment 329423 [details]
Patch v2

Oh it said `and`! cq+
Comment 6 WebKit Commit Bot 2017-12-14 19:26:31 PST 
Comment on attachment 329423 [details]
Patch v2

Clearing flags on attachment: 329423

Committed r225957: <https://trac.webkit.org/changeset/225957>
Comment 7 WebKit Commit Bot 2017-12-14 19:26:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-14 19:28:10 PST 
<rdar://problem/36065806>