Bug 180841

Summary: Make some functions in GraphicsContextCG use call_once for statics
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, graouts, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch graouts: review+

Dean Jackson
Reported 2017-12-14 14:27:00 PST
Make some functions in GraphicsContextCG use call_once for statics
Attachments
Patch (4.25 KB, patch)
2017-12-14 14:35 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2017-12-18 00:51 PST, Dean Jackson 		graouts: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-14 14:27:44 PST
<rdar://problem/36058448>
Dean Jackson
Comment 2 2017-12-14 14:35:18 PST
Created attachment 329405 [details] Patch
Dean Jackson
Comment 3 2017-12-14 15:02:08 PST
Simon already did this... today!
Darin Adler
Comment 4 2017-12-17 10:37:02 PST
I think some big ones for this are going to be: cachedCGColor in ColorCG.cpp nsColor in ColorMac.mm
Dean Jackson
Comment 5 2017-12-18 00:51:18 PST
Reopening to attach new patch.
Dean Jackson
Comment 6 2017-12-18 00:51:21 PST
Created attachment 329643 [details] Patch
Dean Jackson
Comment 7 2017-12-18 14:05:43 PST
Committed r226080: <https://trac.webkit.org/changeset/226080>
Simon Fraser (smfr)
Comment 8 2017-12-18 14:15:49 PST
What about the implementation of linearRGBColorSpaceRef() in GraphicsContextCocoa? Also why you no cc me?
Antoine Quint
Comment 9 2017-12-19 00:18:55 PST
(In reply to Simon Fraser (smfr) from comment #8) > Also why you no cc me? As Dean's manager, you ought to be automatically Cc'd.
Note You need to log in before you can comment on or make changes to this bug.