Bug 180798

Summary: Web Inspector: Styles Redesign: add inline swatch for CSS variables
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2017-12-14 00:06:40 PST
.
Attachments
Patch (4.88 KB, patch)
2017-12-14 00:08 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (46.53 KB, image/png)
2017-12-14 00:08 PST, Devin Rousso 		no flags
Details
Patch (4.90 KB, patch)
2017-12-18 13:42 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-12-14 00:08:26 PST
Created attachment 329331 [details] Patch
Devin Rousso
Comment 2 2017-12-14 00:08:37 PST
Created attachment 329332 [details] [Image] After Patch is applied
Nikita Vasilyev
Comment 3 2017-12-14 16:59:08 PST
Comment on attachment 329331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329331&action=review Looks good! I'm still not a reviewer, so I can't r+. In the future, these "add tokens" functions should have tests and possibly should be moved away from Views. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:503 > + let variableName = tokenValues.find((value, i) => value.startsWith("--") && rawTokens[i].type.includes("variable-2")); Can rawTokens[i].type be null here? > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:513 > + this._hasInvalidVariableValue = true; > + > + newTokens.push(...rawTokens); Nit: this empty line looks odd.
Devin Rousso
Comment 4 2017-12-18 13:42:24 PST
Created attachment 329673 [details] Patch
WebKit Commit Bot
Comment 5 2017-12-18 14:04:39 PST
Comment on attachment 329673 [details] Patch Clearing flags on attachment: 329673 Committed r226079: <https://trac.webkit.org/changeset/226079>
WebKit Commit Bot
Comment 6 2017-12-18 14:04:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-18 14:05:32 PST
<rdar://problem/36115441>
Note You need to log in before you can comment on or make changes to this bug.