Bug 180797

Summary: Web Inspector: Styles Redesign: selecting text should not add new properties
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
none
[Animated GIF] With patch applied none

Nikita Vasilyev
Reported 2017-12-13 20:16:41 PST
Created attachment 329316 [details] [Animated GIF] Bug When trying to copy text, a new property gets added. Steps: 1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/no-trailing-semicolon.html 2. Inspect <body> 3. Click the white space on the right side of "body {" 4. Move cursor after "}" 5. Release the button Expected: Text get selected. No blank properties are added. Actual: Text selection is discarded and new blank property is added.
Attachments
[Animated GIF] Bug (69.36 KB, image/gif)
2017-12-13 20:16 PST, Nikita Vasilyev 		no flags
Details
Patch (1.46 KB, patch)
2017-12-13 20:22 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (91.79 KB, image/gif)
2017-12-13 20:25 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-13 20:16:57 PST
<rdar://problem/36039751>
Nikita Vasilyev
Comment 2 2017-12-13 20:22:48 PST
Created attachment 329317 [details] Patch
Nikita Vasilyev
Comment 3 2017-12-13 20:25:04 PST
Created attachment 329318 [details] [Animated GIF] With patch applied
Devin Rousso
Comment 4 2017-12-14 16:39:39 PST
Comment on attachment 329317 [details] Patch r=me. Nice!
WebKit Commit Bot
Comment 5 2017-12-14 17:00:08 PST
Comment on attachment 329317 [details] Patch Clearing flags on attachment: 329317 Committed r225945: <https://trac.webkit.org/changeset/225945>
WebKit Commit Bot
Comment 6 2017-12-14 17:00:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.