Bug 180795 – Use BlockPtrs and lambdas instead of new/delete to pass parameters to blocks in WebViewImpl::performDragOperation

• Component: New Bugs
• Status: REOPENED

[Alex Christensen]

Use BlockPtrs and lambdas instead of new/delete to pass parameters to blocks in WebViewImpl::performDragOperation

[Alex Christensen]

Created attachment 329311 [details]
Patch

[Brent Fulgham]

Comment on attachment 329311 [details]
Patch

Nice! r=me.

[Alex Christensen]

http://trac.webkit.org/r226330

[Radar WebKit Bug Importer]

<rdar://problem/36260853>

[Andy Estes]

Comment on attachment 329311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329311&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3723
> +            [item receivePromisedFilesAtDestination:dropLocation.get() options:options operationQueue:queue.get() reader:BlockPtr<void(NSURL *, NSError *)>::fromCallable([this, fileNames = WTFMove(fileNames), fileCount, dragData = WTFMove(dragData), pasteboardName](NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) mutable {

You can't move fileNames here. The outer lambda that captured fileNames is called multiple times by -enumerateDraggingItems..., and you'll end up moving from the same variable multiple times, which is illegal.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3729
> +                    if (fileNames.size() == fileCount) {

Because of how fileNames is being moved, this condition will never be true if fileCount is greater than 1.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 183152