Bug 180788

Summary: Make WebsitePolicies a proper class with getters and setters
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aestes: review+

Alex Christensen
Reported 2017-12-13 17:57:14 PST
Make WebsitePolicies a proper class with getters and setters
Attachments
Patch (22.15 KB, patch)
2017-12-13 18:00 PST, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-12-13 18:00:05 PST
Created attachment 329301 [details] Patch
Andy Estes
Comment 2 2017-12-14 13:10:31 PST
Comment on attachment 329301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329301&action=review > Source/WebKit/Shared/WebsitePolicies.h:71 > + const Vector<WebCore::HTTPHeaderField>& customHeaderFields() { return m_customHeaderFields; } Should be const-qualified. > Source/WebKit/UIProcess/API/APIWebsitePolicies.h:50 > + const Vector<WebCore::HTTPHeaderField> customHeaderFields() { return m_websitePolicies.customHeaderFields(); } Should be const-qualified. It's also weird to return a const value.
Alex Christensen
Comment 3 2017-12-14 14:07:58 PST
http://trac.webkit.org/r225925
Radar WebKit Bug Importer
Comment 4 2017-12-14 14:08:21 PST
<rdar://problem/36057847>
Note You need to log in before you can comment on or make changes to this bug.