Summary: | Arrow functions need their own structure because they have different properties than sloppy functions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2017-12-13 16:06:57 PST
Here is an example of get being broken: ``` function assert(b) { if (!b) throw new Error; } function foo(f) { return f.prototype; } { let f1 = function () { }; let f2 = () => undefined; for (let i = 0; i < 100; ++i) assert(foo(f2) === undefined); assert(foo(f1) !== undefined); } ``` I think JF recently fixed a similar issue w/ strict vs sloppy mode functions. Created attachment 329298 [details]
patch
Comment on attachment 329298 [details]
patch
r=me
Comment on attachment 329298 [details] patch Clearing flags on attachment: 329298 Committed r225891: <https://trac.webkit.org/changeset/225891> All reviewed patches have been landed. Closing bug. Comment on attachment 329298 [details]
patch
Belated r=me too
|