Summary: | Web Inspector: Cmd-Option-R in docked inspector causes the inspector to reload instead of the inspected page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-12-13 15:29:14 PST
Created attachment 329271 [details]
[PATCH] Proposed Fix
Comment on attachment 329271 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329271&action=review Looks good but please fix build issues then I'll mark r+ > Source/WebKit/UIProcess/mac/WKInspectorViewController.mm:237 > + if (linkedOnOrAfter(WebKit::SDKVersion::FirstWithExpiredOnlyReloadBehavior)) Didn't know we had this now, cool. > Source/WebKit/UIProcess/mac/WKInspectorWKWebView.h:38 > +@protocol WKInspectorWKWebViewIBDelegate This protocol name bothers me. It shouldn't mention IB since there are no IB types/macros in the signature. How about just @protocol WKInspectorWKWebViewDelegate? > How about just @protocol WKInspectorWKWebViewDelegate?
Yeah, sounds good.
Created attachment 329321 [details]
[PATCH] Proposed Fix
Created attachment 329322 [details]
[PATCH] Proposed Fix
Better patch with -M100% so git doesn't think new files are from old files...
Comment on attachment 329322 [details]
[PATCH] Proposed Fix
r=e
Comment on attachment 329322 [details] [PATCH] Proposed Fix Clearing flags on attachment: 329322 Committed r225907: <https://trac.webkit.org/changeset/225907> All reviewed patches have been landed. Closing bug. |