Bug 180721 – is<HTMLTextFormControlElement> reports the input type.

• Component: Forms
• Status: RESOLVED FIXED

[zalan]

but it is expected to report the class type.

[Radar WebKit Bug Importer]

<rdar://problem/36005123>

[zalan]

Created attachment 329162 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 329162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329162&action=review

> Source/WebCore/editing/Editor.cpp:247
> +    if (is<Element>(event->target()) && downcast<Element>(*event->target()).isTextField()) {
>          auto& target = downcast<HTMLTextFormControlElement>(*event->target());

Here, we should probably check both is<HTMLTextFormControlElement>(event->target()) and downcast<Element>(*event->target()).isTextField()
so that downcast & is match.

> Source/WebCore/editing/Editor.cpp:1724
> -    if (is<HTMLTextFormControlElement>(focusedElement)) {
> +    if (focusedElement && focusedElement->isTextField()) {

Ditto.

[zalan]

Created attachment 329163 [details]
Patch

[EWS Watchlist]

Comment on attachment 329163 [details]
Patch

Attachment 329163 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5637053

New failing tests:
fast/selectors/placeholder-shown-style-update.html

[EWS Watchlist]

Created attachment 329173 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 329163 [details]:

The commit-queue is continuing to process your patch.

[zalan]

Created attachment 329193 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 329193 [details]
Patch

Clearing flags on attachment: 329193

Committed r225837: <https://trac.webkit.org/changeset/225837>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.