Bug 180694

Summary: [GTK][WebRTC] Stop warning with so much verbosity about not implemented RealtimeMediaSourceCenter
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, alex, bugs-noreply, darin, eric.carlson, sam, youennf
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2017-12-12 07:08:53 PST
This warning is too much verbose, when running the tests lots of warnings are printed.
Example: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4646/steps/API%20tests/logs/stdio

/webkit2/WebKitWebView/insert/image:                                 WebKitGTK LIBWEBRTC RealtimeMediaSourceCenter NOT IMPLEMENTED. Returning MockRealtimeMediaSourceCenter instead to avoid crash!

WebKitGTK LIBWEBRTC RealtimeMediaSourceCenter NOT IMPLEMENTED. Returning MockRealtimeMediaSourceCenter instead to avoid crash!

OK

/webkit2/WebKitWebView/insert/link:                                  WebKitGTK LIBWEBRTC RealtimeMediaSourceCenter NOT IMPLEMENTED. Returning MockRealtimeMediaSourceCenter instead to avoid crash!

WebKitGTK LIBWEBRTC RealtimeMediaSourceCenter NOT IMPLEMENTED. Returning MockRealtimeMediaSourceCenter instead to avoid crash!

OK

[....]


There is no need for this.
Comment 1 Carlos Alberto Lopez Perez 2017-12-12 07:13:49 PST
Created attachment 329110 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-12-12 08:46:15 PST
Comment on attachment 329110 [details]
Patch

Clearing flags on attachment: 329110

Committed r225783: <https://trac.webkit.org/changeset/225783>
Comment 3 Carlos Alberto Lopez Perez 2017-12-12 08:46:19 PST
All reviewed patches have been landed.  Closing bug.