Bug 180681 – Storage Access API: Make document.hasStorageAccess() retrieve current status from the network process

• Component: WebKit2
• Status: RESOLVED FIXED

[John Wilander]

This is part 2 of making Storage Access API frame-specific.

[Radar WebKit Bug Importer]

<rdar://problem/35982161>

[John Wilander]

Created attachment 329522 [details]
Patch

[John Wilander]

Style errors are all of the "Extra space before ( in function call" variety.

[EWS Watchlist]

Attachment 329522 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1436:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:257:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:352:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ChromeClient.h:470:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:5780:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:150:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1027:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:1259:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 329522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329522&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:268
> +});

indentation

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:81
> +    void hasStorageAccessForPrevalentDomains(PAL::SessionID, const String& resourceDomain, const String& firstPartyDomain, uint64_t frameID, uint64_t pageID, WTF::CompletionHandler<void(bool)>&& callback);

WTF:: prefix should be unnecessary

[Alex Christensen]

Comment on attachment 329522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329522&action=review

> Source/WebCore/dom/Document.cpp:7430
> -    RefPtr<DeferredPromise> promise(WTFMove(passedPromise));
> +    RefPtr<DeferredPromise>&& promise(WTFMove(passedPromise));

We shouldn't need this at all.  We should be able to just use a Ref and call the passedPromise promise.

[John Wilander]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 329522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329522&action=review
> 
> > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:268
> > +});
> 
> indentation

Fixed.

> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:81
> > +    void hasStorageAccessForPrevalentDomains(PAL::SessionID, const String& resourceDomain, const String& firstPartyDomain, uint64_t frameID, uint64_t pageID, WTF::CompletionHandler<void(bool)>&& callback);
> 
> WTF:: prefix should be unnecessary

OK.

[John Wilander]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 329522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329522&action=review
> 
> > Source/WebCore/dom/Document.cpp:7430
> > -    RefPtr<DeferredPromise> promise(WTFMove(passedPromise));
> > +    RefPtr<DeferredPromise>&& promise(WTFMove(passedPromise));
> 
> We shouldn't need this at all.  We should be able to just use a Ref and call
> the passedPromise promise.

This was actually me trying to figure out weird promise behavior. Turned out to be something else. Fixed.

[John Wilander]

I know what the WK2 test timeouts are about. New patch coming.

[John Wilander]

Created attachment 329536 [details]
Patch

[EWS Watchlist]

Attachment 329536 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1436:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:257:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:352:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ChromeClient.h:470:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:5780:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:150:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1027:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:1259:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 329536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329536&action=review

> Source/WebCore/dom/Document.cpp:7430
> +    RefPtr<DeferredPromise>&& promise(WTFMove(passedPromise));

Delete this line, change the parameter name from passedPromise to promise, and change the lambda capture from promise to promise = WTFMove(promise)

[John Wilander]

Created attachment 329630 [details]
Patch for landing

[John Wilander]

(In reply to Alex Christensen from comment #12)
> Comment on attachment 329536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329536&action=review
> 
> > Source/WebCore/dom/Document.cpp:7430
> > +    RefPtr<DeferredPromise>&& promise(WTFMove(passedPromise));
> 
> Delete this line, change the parameter name from passedPromise to promise,
> and change the lambda capture from promise to promise = WTFMove(promise)

Fixed. Thanks for the review, Alex!

[WebKit Commit Bot]

Comment on attachment 329630 [details]
Patch for landing

Clearing flags on attachment: 329630

Committed r226016: <https://trac.webkit.org/changeset/226016>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.