Bug 180616

Summary: Disable NoEventDispatchAssertion release assertion in WebKit1
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Disable release assertions in WK1 none

Ryosuke Niwa
Reported 2017-12-08 16:54:52 PST
There are just many delegate callbacks inside WebCore in unsafe places, and embedder of WebView can execute scripts, or modify WebView in all those sites. Since we don't have a hope of fixing all those delegate callbacks in short term, disable the release assertion added in https://trac.webkit.org/r224534 in WebKit1.
Attachments
Disable release assertions in WK1 (6.72 KB, patch)
2017-12-08 17:06 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-12-08 17:06:03 PST
*** Bug 180617 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 2 2017-12-08 17:06:47 PST
Created attachment 328889 [details] Disable release assertions in WK1
Ryosuke Niwa
Comment 3 2017-12-08 17:12:50 PST
<rdar://problem/35689400>
Ryosuke Niwa
Comment 4 2017-12-11 19:02:33 PST
Ping reviewers.
Ryosuke Niwa
Comment 5 2017-12-11 22:10:01 PST
Comment on attachment 328889 [details] Disable release assertions in WK1 cq+. Confirmed that the assertion still requires on macOS.
WebKit Commit Bot
Comment 6 2017-12-11 22:30:37 PST
Comment on attachment 328889 [details] Disable release assertions in WK1 Clearing flags on attachment: 328889 Committed r225772: <https://trac.webkit.org/changeset/225772>
WebKit Commit Bot
Comment 7 2017-12-11 22:30:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.