Summary: | [python] Replace print >> operator with print() function for python3 compatibility | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||
Component: | Tools / Tests | Assignee: | Konstantin Tokarev <annulen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbates, don.olmstead, ews-watchlist, glenn, keith_miller, lforschler, mark.lam, mcatanzaro, msaboff, rniwa, saam, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Konstantin Tokarev
2017-12-08 15:22:06 PST
Created attachment 328878 [details]
Patch
Comment on attachment 328878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328878&action=review OK, just watch webkitpy tests after it lands. > Source/JavaScriptCore/Scripts/make-js-file-arrays.py:24 > +from __future__ import print_function Do we have a plan for how to handle the migration for macOS? I expect python3 will just have to become a build requirement, right? For now there is no migration, all code is valid python2, it just will be gradually made compatible with python3. To avoid regressions, we'll need to add pylint --py3k to style checker, and probably use python3 on some bot after it can work. I mean it's a "modernization", not "migration" :) Comment on attachment 328878 [details] Patch Clearing flags on attachment: 328878 Committed r225724: <https://trac.webkit.org/changeset/225724> All reviewed patches have been landed. Closing bug. |