Bug 180611

Summary: [python] Replace print >> operator with print() function for python3 compatibility
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, don.olmstead, ews-watchlist, glenn, keith_miller, lforschler, mark.lam, mcatanzaro, msaboff, rniwa, saam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2017-12-08 15:22:06 PST
This patch converts uses of print with files or streams
Attachments
Patch (36.25 KB, patch)
2017-12-08 15:24 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-12-08 15:24:40 PST
Created attachment 328878 [details] Patch
Michael Catanzaro
Comment 2 2017-12-09 08:29:17 PST
Comment on attachment 328878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328878&action=review OK, just watch webkitpy tests after it lands. > Source/JavaScriptCore/Scripts/make-js-file-arrays.py:24 > +from __future__ import print_function Do we have a plan for how to handle the migration for macOS? I expect python3 will just have to become a build requirement, right?
Konstantin Tokarev
Comment 3 2017-12-09 08:35:42 PST
For now there is no migration, all code is valid python2, it just will be gradually made compatible with python3. To avoid regressions, we'll need to add pylint --py3k to style checker, and probably use python3 on some bot after it can work.
Konstantin Tokarev
Comment 4 2017-12-09 08:36:28 PST
I mean it's a "modernization", not "migration" :)
WebKit Commit Bot
Comment 5 2017-12-09 08:58:40 PST
Comment on attachment 328878 [details] Patch Clearing flags on attachment: 328878 Committed r225724: <https://trac.webkit.org/changeset/225724>
WebKit Commit Bot
Comment 6 2017-12-09 08:58:42 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-09 08:59:44 PST
<rdar://problem/35952328>
Note You need to log in before you can comment on or make changes to this bug.