Bug 180609

Summary: APIClient.h uses things from <tuple> without including it explicitly
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, don.olmstead, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add <tuple> include to APIClient.h none

Stephan Szabo
Reported 2017-12-08 14:54:05 PST
Similar to https://bugs.webkit.org/show_bug.cgi?id=179926, APIClient.h uses tuple related items without explicitly including <tuple>. This can cause compilation failures on toolchains where including <algorithm> and <array> doesn't guarantee the appropriate tuple_size and tuple_element used in the header being available.
Attachments
Add <tuple> include to APIClient.h (888 bytes, patch)
2017-12-08 16:57 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2017-12-08 16:57:41 PST
Created attachment 328886 [details] Add <tuple> include to APIClient.h
WebKit Commit Bot
Comment 2 2017-12-10 08:47:28 PST
Comment on attachment 328886 [details] Add <tuple> include to APIClient.h Clearing flags on attachment: 328886 Committed r225732: <https://trac.webkit.org/changeset/225732>
WebKit Commit Bot
Comment 3 2017-12-10 08:47:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-12-10 08:48:36 PST
<rdar://problem/35956521>
Note You need to log in before you can comment on or make changes to this bug.