Bug 180603

Summary: Implement transferToImageBitmap for WebGL offscreen canvas objects
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryanhaddad, sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2017-12-08 13:50:07 PST
Implement transferToImageBitmap for WebGL offscreen canvas objects
Attachments
Patch (11.12 KB, patch)
2017-12-08 13:57 PST, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-12-08 13:53:31 PST
<rdar://problem/34147143>
Dean Jackson
Comment 2 2017-12-08 13:57:16 PST
Created attachment 328866 [details] Patch
Sam Weinig
Comment 3 2017-12-08 14:00:21 PST
Comment on attachment 328866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328866&action=review > Source/WebCore/html/ImageBitmap.cpp:57 > +RefPtr<ImageBitmap> ImageBitmap::create(IntSize size) Any reason not to return a Ref<ImageBitmap> here? > Source/WebCore/html/ImageBitmap.cpp:59 > + RefPtr<ImageBitmap> imageBitmap = adoptRef(new ImageBitmap); You can use auto here.
Dean Jackson
Comment 4 2017-12-08 14:48:26 PST
Committed r225706: <https://trac.webkit.org/changeset/225706>
Ryan Haddad
Comment 5 2017-12-08 15:09:39 PST
This change broke the El Capitan and Sierra build: /Volumes/Data/slave/sierra-32bit-release/build/Source/WebCore/html/OffscreenCanvas.cpp:130:12: error: no viable conversion from returned value of type 'WTF::Ref<WebCore::ImageBitmap>' to function return type 'RefPtr<WebCore::ImageBitmap>' https://build.webkit.org/builders/Apple%20Sierra%20Release%20%2832-bit%20Build%29/builds/7348 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%28Build%29/builds/7210
Fujii Hironori
Comment 6 2017-12-08 15:51:13 PST
AppleWin port also gets broken. https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6463
Note You need to log in before you can comment on or make changes to this bug.