Bug 18059

Summary: squirrelfish needs to compile on platforms without computed goto
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
First run at the patch ggaren: review+

Oliver Hunt
Reported 2008-03-24 21:40:03 PDT
Tracking bug
Attachments
First run at the patch (11.08 KB, patch)
2008-03-24 21:45 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2008-03-24 21:45:35 PDT
Created attachment 20021 [details] First run at the patch Formatting of the runloop should be indented one level, but that will screw anyone with unlanded changes. Also not entirely sure about having the computed goto conditionalised on the compiler support computed goto -- may be better to have an explicit (independent) flag later.
Geoffrey Garen
Comment 2 2008-03-24 21:59:05 PDT
+ ASSERT(isOpcode(opcode)); return m_opcodeIDTable.get(opcode); Please move this onto two lines.
Oliver Hunt
Comment 3 2008-03-24 22:08:00 PDT
Landed r31276
Note You need to log in before you can comment on or make changes to this bug.