Bug 180556

Summary:

Make inline box objects IsoHeap allocated.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, fpizlo, fujii.hironori, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none

alan

Reported 2017-12-07 16:53:11 PST

ssia.

Attachments
Patch (13.45 KB, patch) 2017-12-07 16:57 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.84 MB, application/zip) 2017-12-07 18:33 PST, EWS Watchlist	no flags	Details
Patch (22.78 KB, patch) 2017-12-08 14:20 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-12-07 16:54:27 PST

<rdar://problem/35923629>

alan

Comment 2 2017-12-07 16:57:03 PST

Created attachment 328756 [details] Patch

EWS Watchlist

Comment 3 2017-12-07 18:33:26 PST

Comment on attachment 328756 [details] Patch Attachment 328756 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5536935 New failing tests: fast/text/vertical-rl-rtl-linebreak.html

EWS Watchlist

Comment 4 2017-12-07 18:33:28 PST

Created attachment 328770 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

alan

Comment 5 2017-12-07 18:42:44 PST

(In reply to Build Bot from comment #4) > Created attachment 328770 [details] > Archive of layout-test-results from ews105 for mac-elcapitan-wk2 > > The attached test failures were seen while running run-webkit-tests on the > mac-wk2-ews. > Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6 oh rly

Fujii Hironori

Comment 6 2017-12-07 20:50:18 PST

(In reply to Build Bot from comment #3) > Comment on attachment 328756 [details] > Patch > > Attachment 328756 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/5536935 > > New failing tests: > fast/text/vertical-rl-rtl-linebreak.html I filed Bug 180570 for fast/text/vertical-rl-rtl-linebreak.html crash.

alan

Comment 7 2017-12-07 20:51:35 PST

(In reply to Fujii Hironori from comment #6) > (In reply to Build Bot from comment #3) > > Comment on attachment 328756 [details] > > Patch > > > > Attachment 328756 [details] did not pass mac-wk2-ews (mac-wk2): > > Output: http://webkit-queues.webkit.org/results/5536935 > > > > New failing tests: > > fast/text/vertical-rl-rtl-linebreak.html > > I filed Bug 180570 for fast/text/vertical-rl-rtl-linebreak.html crash. Thanks.

Filip Pizlo

Comment 8 2017-12-08 11:58:22 PST

Comment on attachment 328756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328756&action=review > Source/WebCore/rendering/TrailingFloatsRootInlineBox.h:47 > +WTF_MAKE_ISO_ALLOCATED_IMPL(TrailingFloatsRootInlineBox); Better to move this to a .cpp to avoid #including IsoMallocInlines in too many places

alan

Comment 9 2017-12-08 14:20:20 PST

Created attachment 328868 [details] Patch

WebKit Commit Bot

Comment 10 2017-12-08 15:32:20 PST

Comment on attachment 328868 [details] Patch Clearing flags on attachment: 328868 Committed r225712: <https://trac.webkit.org/changeset/225712>

WebKit Commit Bot

Comment 11 2017-12-08 15:32:21 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.