Summary: | Simplify log channel configuration UI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
Component: | Web Inspector | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, inspector-bugzilla-changes, jlewis3, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Eric Carlson
2017-12-07 06:39:21 PST
Created attachment 328692 [details]
Proposed patch
Comment on attachment 328692 [details]
Proposed patch
r=me
Comment on attachment 328692 [details] Proposed patch Clearing flags on attachment: 328692 Committed r225634: <https://trac.webkit.org/changeset/225634> All reviewed patches have been landed. Closing bug. This patch caused the Layout test inspector/console/webcore-logging.html to timeout with a text difference consistently on High Sierra and Sierra: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r225635%20(1868)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/1868 Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/console/webcore-logging-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/console/webcore-logging-actual.txt @@ -1,3 +1,4 @@ +FAIL: Timed out waiting for notifyDone to be called Test WebKit logging configuration and console display. @@ -27,6 +28,8 @@ -- Running test case: Console.Logging.MediaLogging PASS: Media logging disabled. -PASS: Media logging has been enabled. -PASS: Media log message should have source 'media'. +ERROR: Protocol Error: Invalid type of argument 'level' for command 'Console.setLoggingChannelLevel' call. It must be 'string' but it is 'undefined'. +FAIL: Media logging has been enabled. + Expected: truthy + Actual: false I was able to reproduce the timeout locally and when I tested before this patch the timeout was not reproducible. Reverted r225634 for reason: This caused layout tests to time out. Committed r225643: <https://trac.webkit.org/changeset/225643> > -- Running test case: Console.Logging.MediaLogging
> PASS: Media logging disabled.
> -PASS: Media logging has been enabled.
> -PASS: Media log message should have source 'media'.
> +ERROR: Protocol Error: Invalid type of argument 'level' for command
> 'Console.setLoggingChannelLevel' call. It must be 'string' but it is
> 'undefined'.
> +FAIL: Media logging has been enabled.
> + Expected: truthy
> + Actual: false
Oo. Looks like these two lines in the test need to change:
ConsoleAgent.setLoggingChannelLevel(channel.source, WI.LoggingChannel.Level.Log);
...
InspectorTest.expectThat(mediaChannel.level === WI.LoggingChannel.Level.Log, "Media logging has been enabled.");
From "Level.Log" to "Level.Basic", since "Level.Log" no longer exists.
Created attachment 328760 [details]
Updated patch.
Comment on attachment 328760 [details] Updated patch. Clearing flags on attachment: 328760 Committed r225663: <https://trac.webkit.org/changeset/225663> All reviewed patches have been landed. Closing bug. |