Bug 180512

Summary:

Remove unnecessary prefix from AutoFillButtonType enumerators

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, aestes, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, lforschler, rniwa, samuel_white, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none

Daniel Bates

Reported 2017-12-06 16:49:33 PST

Remove unnecessary "AutoFillButtonType" prefix from AutoFillButtonType enumerators.

Attachments
Patch (17.69 KB, patch) 2017-12-06 16:50 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.77 MB, application/zip) 2017-12-06 19:04 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-12-06 16:50:19 PST

<rdar://problem/35896664>

Daniel Bates

Comment 2 2017-12-06 16:50:42 PST

Created attachment 328653 [details] Patch

EWS Watchlist

Comment 3 2017-12-06 19:04:21 PST

Comment on attachment 328653 [details] Patch Attachment 328653 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5523902 New failing tests: http/tests/inspector/network/resource-response-service-worker.html imported/w3c/web-platform-tests/streams/readable-byte-streams/brand-checks.serviceworker.https.html

EWS Watchlist

Comment 4 2017-12-06 19:04:23 PST

Created attachment 328671 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Daniel Bates

Comment 5 2017-12-06 19:32:51 PST

(In reply to Build Bot from comment #3) > Comment on attachment 328653 [details] > Patch > > Attachment 328653 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/5523902 > > New failing tests: > http/tests/inspector/network/resource-response-service-worker.html > imported/w3c/web-platform-tests/streams/readable-byte-streams/brand-checks. > serviceworker.https.html These failures represent flaky crashes and are not caused by this patch.

Daniel Bates

Comment 6 2017-12-06 19:47:42 PST

(In reply to Daniel Bates from comment #5) > (In reply to Build Bot from comment #3) > > Comment on attachment 328653 [details] > > Patch > > > > Attachment 328653 [details] did not pass mac-wk2-ews (mac-wk2): > > Output: http://webkit-queues.webkit.org/results/5523902 > > > > New failing tests: > > http/tests/inspector/network/resource-response-service-worker.html > > imported/w3c/web-platform-tests/streams/readable-byte-streams/brand-checks. > > serviceworker.https.html > > These failures represent flaky crashes and are not caused by this patch. Filed bug #180518.

Daniel Bates

Comment 7 2017-12-08 14:51:30 PST

Comment on attachment 328653 [details] Patch Clearing flags on attachment: 328653 Committed r225707: <https://trac.webkit.org/changeset/225707>

Daniel Bates

Comment 8 2017-12-08 14:51:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.