Bug 180511

Summary:

[css-grid] Remove duplicated tests that are now present in WPT

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jfernandez, lforschler, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=767015

Bug Depends on:

180345

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Manuel Rego Casasnovas

Reported 2017-12-06 16:22:56 PST

Some tests have been moved to WPT in Blink: * https://chromium-review.googlesource.com/c/chromium/src/+/674931 * https://chromium-review.googlesource.com/c/chromium/src/+/730707 As now we've updated the suite in bug #180345, we can get rid of those duplicated tests that are now present in WPT and that we don't need under fast/css-grid-layout/.

Attachments
Patch (198.27 KB, patch) 2017-12-06 16:25 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch for landing (198.30 KB, patch) 2017-12-07 03:18 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2017-12-06 16:25:47 PST

Created attachment 328649 [details] Patch

WebKit Commit Bot

Comment 2 2017-12-06 17:04:59 PST

Comment on attachment 328649 [details] Patch Rejecting attachment 328649 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 328649, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/5522676

Manuel Rego Casasnovas

Comment 3 2017-12-07 03:18:15 PST

Created attachment 328686 [details] Patch for landing

WebKit Commit Bot

Comment 4 2017-12-07 03:54:40 PST

Comment on attachment 328686 [details] Patch for landing Clearing flags on attachment: 328686 Committed r225624: <https://trac.webkit.org/changeset/225624>

WebKit Commit Bot

Comment 5 2017-12-07 03:54:43 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2017-12-07 03:56:00 PST

<rdar://problem/35906559>

Note You need to log in before you can comment on or make changes to this bug.