Bug 180498

Summary: When the iPhone keyboard is up, sometimes we never commit a stable update and re-show the caret
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, younatics
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2017-12-06 13:15:09 PST
When the iPhone keyboard is up, sometimes we never commit a stable update and re-show the caret
Comment 1 Simon Fraser (smfr) 2017-12-06 13:18:35 PST
Created attachment 328614 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-12-06 13:19:06 PST
<rdar://problem/35890095>
Comment 3 Tim Horton 2017-12-06 13:23:29 PST
Comment on attachment 328614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328614&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1628
> +    UIEdgeInsets contentInsets = scrollView.adjustedContentInset;
> +#else
>      UIEdgeInsets contentInsets = scrollView.contentInset;
> +#endif

We likely need to audit other use of contentInset.
Comment 4 Simon Fraser (smfr) 2017-12-08 16:00:42 PST
https://trac.webkit.org/r225714
Comment 5 Seungyoun Yi 2017-12-11 18:23:17 PST
Hello! 

Thanks for fixing this issue! 
This is one of our major problem in Never Keyboard! :)

Again, thanks a lot and please release this Webkit! 

Thank you!
Seungyoun Yi
Comment 6 Seungyoun Yi 2017-12-11 18:24:25 PST
Ooops Naver Keyboard.
I tested in simulator and works great!
Comment 7 Simon Fraser (smfr) 2017-12-11 18:33:01 PST
Did you file a separate bug report for this?
Comment 8 Seungyoun Yi 2017-12-11 18:37:05 PST
Nope, I research WebKit bugs to report this bug, but I found same issue in here.

However, I report this bug but not finished yet.. lol.

https://bugs.webkit.org/show_bug.cgi?id=179602 (rdar://problem/34969608)

I think this bug is hard :(

Whatever, Thanks!
Seungyoun Yi