Bug 180468

Summary: Move security origin filtering for getMatchedCSSRules out of StyleResolver
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2017-12-06 05:05:00 PST
The code is overly invasive and blocks optimizations.
Attachments
patch (28.64 KB, patch)
2017-12-06 05:16 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-12-06 05:16:05 PST
Created attachment 328563 [details] patch
WebKit Commit Bot
Comment 2 2017-12-07 11:25:40 PST
Comment on attachment 328563 [details] patch Rejecting attachment 328563 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 328563, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 4246628642abddd6ef6e3d219a204e62cf169ca2 a5732ba6c92a2d2df6765b81c8c1e1bc798e207c M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/5531894
WebKit Commit Bot
Comment 3 2017-12-07 15:58:43 PST
Comment on attachment 328563 [details] patch Clearing flags on attachment: 328563 Committed r225650: <https://trac.webkit.org/changeset/225650>
WebKit Commit Bot
Comment 4 2017-12-07 15:58:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-07 15:59:22 PST
<rdar://problem/35922094>
Note You need to log in before you can comment on or make changes to this bug.