| Summary: | [Mac] REGRESSION (r224527): Drawing a path with box-shadow takes double the blur-radius on Retina display | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dbates, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||||||
| Priority: | P1 | Keywords: | InRadar, PlatformOnly, Regression | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | macOS 10.13 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 328529 [details]
screen shot
Created attachment 328535 [details]
Patch
Please update the title in the ChangeLog before landing. I added a space character between “REGRESSION” and ‘(‘. Please also add the radar bug URL under the Buzilla bug URLin the ChangeLog. Created attachment 328577 [details]
Patch
Comment on attachment 328577 [details] Patch Clearing flags on attachment: 328577 Committed r225575: <https://trac.webkit.org/changeset/225575> All reviewed patches have been landed. Closing bug. Comment on attachment 328577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328577&action=review > Source/WebCore/ChangeLog:10 > + Disable using CGContextDrawPathDirect() for macOS High Sierra or earlier. > + This API has a bug when drawing a path with a shadow on Retina display. You should reference the underlying radar. Comment on attachment 328577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328577&action=review >> Source/WebCore/ChangeLog:10 >> + This API has a bug when drawing a path with a shadow on Retina display. > > You should reference the underlying radar. Done. <https://trac.webkit.org/changeset/225586> |
Created attachment 328528 [details] test case Open the attached test case on High Sierra MacOS Retina display. Result: the box-shadow of the rounded rectangle does not render correctly. It looks as if the blur-radius is doubled (See the attached picture which compares the correct display and the wrong display).